2024-10-08T09:23:01.923Z | <Venky Shankar> @Milind Changire quick question (re: <https://github.com/ceph/ceph/pull/60058/files>) there are two threadid_name maps. Any reason why? |
2024-10-08T09:26:40.069Z | <Venky Shankar> The static vars seem fine, but why do we need the per-thread map? |
2024-10-08T10:04:21.349Z | <Venky Shankar> The map is only required as a singleton afaict. |
2024-10-08T10:18:23.304Z | <Milind Changire> I've used the old method:
1. of declaring class `static` members inside the class declaration
2. and defining the class `static` members in [Thread.cc](http://Thread.cc)
Those are not two maps.
I'll just change the `static` declaration to `static inline` to do away with confusion (`static inline` is allowed since C+++17) |
2024-10-08T10:19:28.543Z | <Milind Changire> I've used the old method:
1. of declaring class `static` members inside the class declaration
2. and defining the class `static` members in Thread.cc
Those are not two maps.
I'll just change the `static` declaration to `static inline` to do away with confusion (`static inline` is allowed since C++17) |
2024-10-08T10:30:25.400Z | <Venky Shankar> Ah kk |
2024-10-08T10:30:26.916Z | <Venky Shankar> I see |
2024-10-08T10:30:46.928Z | <Venky Shankar> The static in the cc source was probably causing the confusion |
2024-10-08T10:30:57.151Z | <Venky Shankar> Normally I just drop that |
2024-10-08T10:31:31.178Z | <Milind Changire> ack |
2024-10-08T10:31:43.859Z | <Milind Changire> I'll refresh the PR in a bit |
2024-10-08T10:37:22.737Z | <Igor Golikov> Hi it looks that vossi04 has dns issues. Can I reboot it? |
2024-10-08T10:37:32.826Z | <Igor Golikov> (not sure I have sudo access) |
2024-10-08T10:38:04.165Z | <Venky Shankar> Ask Adam kraitman if possibel |
2024-10-08T10:39:49.444Z | <Venky Shankar> (and it looked like the map was per thread, which is not the case, so 👍 ) |
2024-10-08T10:40:50.908Z | <Igor Golikov> thanks |
2024-10-08T10:50:15.948Z | <Milind Changire> PR updated |
2024-10-08T11:59:04.436Z | <Venky Shankar> @Milind Changire could you please run standup for today? |
2024-10-08T12:32:30.186Z | <Milind Changire> ack |
2024-10-08T13:38:03.858Z | <Patrick Donnelly> Hard to say, I'm not sure how this netfs readahead is even triggered |
2024-10-08T13:38:09.017Z | <Patrick Donnelly> despite banging on it for a while |
2024-10-08T13:38:20.540Z | <Patrick Donnelly> but for this reddit post, 5.15 does not have the bug |